Replace tailscale binary with tailscaled unix socket #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
approved these changes
Jun 28, 2023
tylersmalley
pushed a commit
that referenced
this pull request
Jun 29, 2023
We currently check for existence of the `tailscale` binary just for guessing at whether you have tailscale installed. However, we already show a similar message when tsrelay returns a NOT_RUNNING state. Furthermore, showing those pop ups on first install when we already have a walkthrough to show you how to install Tailscale is not a pleasant experience. Therefore, this PR removes the manual checks for the binary and switches the VSCode configuration to be for setting the unix socket Updates #76 (cherry picked from commit cf36726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently check for existence of the
tailscalebinary just for guessing at whether you have tailscale installed. However, we already show a similar message when tsrelay returns a NOT_RUNNING state.Furthermore, showing those pop ups on first install when we already have a walkthrough to show you how to install Tailscale is not a pleasant experience.
Therefore, this PR removes the manual checks for the binary and switches the VSCode configuration to be for setting the unix socket
Updates #76