Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flatpak-spawn when pkexec is needed #86

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Run flatpak-spawn when pkexec is needed #86

merged 3 commits into from
Jun 28, 2023

Conversation

marwan-at-work
Copy link
Contributor

@marwan-at-work marwan-at-work commented Jun 28, 2023 •
edited
Loading

This PR checks the env vars to see if we're running inside of flatpak, and if saw prepends the pkexec with flatpak-spawn in order rerun tsrelay as sudo.

We also run flatpak override so the user doesn't have to.

Fixes #76

tylersmalley
tylersmalley approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one naming suggestion

@marwan-at-work marwan-at-work merged commit cf322bb into main Jun 28, 2023
2 checks passed
@marwan-at-work marwan-at-work deleted the marwan/flatpak branch June 28, 2023 21:41
tylersmalley pushed a commit that referenced this pull request Jun 29, 2023
@marwan-at-work @tylersmalley
Run flatpak-spawn when pkexec is needed (#86)
079a553 
This PR checks the env vars to see if we're running inside of flatpak,
and if saw prepends the pkexec with flatpak-spawn in order rerun tsrelay
as sudo.

We also run `flatpak override` so the user doesn't have to.

Fixes #76

(cherry picked from commit cf322bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Flatpak installations
2 participants
@marwan-at-work @tylersmalley