Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Combobox component #1047

Merged
merged 79 commits into from
Jan 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
b8ecaf1
start of combobox
RobinMalfait Jan 18, 2022
3fa9a96
start with a copy of the Listbox
RobinMalfait Jan 18, 2022
ad48b79
WIP
RobinMalfait Jan 18, 2022
c08763f
Add Vue Combobox
thecrypticace Jan 18, 2022
16e3e70
Update Vue version of combobox
thecrypticace Jan 18, 2022
53511fb
Update tests
thecrypticace Jan 18, 2022
b7256eb
Fix typescript errors in combobox test
thecrypticace Jan 19, 2022
33b202d
Fix input label
thecrypticace Jan 19, 2022
df9cc98
Add active descendant to combobox/input
thecrypticace Jan 19, 2022
5244baa
Add listbox role to comobox options
thecrypticace Jan 19, 2022
d015a19
Update tests
thecrypticace Jan 19, 2022
bc0ea7f
move React playground to dedicated package
RobinMalfait Jan 20, 2022
b289928
add react playground script to root
RobinMalfait Jan 20, 2022
2154ccd
ensure we only open/close the combobox when necessary
RobinMalfait Jan 20, 2022
10b6568
ensure export order is correct
RobinMalfait Jan 20, 2022
ae05277
remove leftover pages directory from React package
RobinMalfait Jan 20, 2022
668af88
Only add aria controls when combobox is open
thecrypticace Jan 20, 2022
8a79fa2
add missing next commands
RobinMalfait Jan 20, 2022
342900a
make typescript happy
RobinMalfait Jan 20, 2022
afe2dcd
build @headlessui/react before building playground-react
RobinMalfait Jan 20, 2022
193515e
add empty public folder
RobinMalfait Jan 20, 2022
b2c5595
wip
RobinMalfait Jan 20, 2022
70d32b0
Add todo
thecrypticace Jan 20, 2022
0a6e202
Update tests
thecrypticace Jan 20, 2022
fcaf092
change default combobox example slightly
RobinMalfait Jan 21, 2022
bea6ff6
ensure that we sync the input with new state
RobinMalfait Jan 21, 2022
bb86c75
only sync the value with the input in a single spot
RobinMalfait Jan 21, 2022
f9f6c39
WIP: object value to string
RobinMalfait Jan 21, 2022
855a37f
WIP
RobinMalfait Jan 21, 2022
8162d5b
WIP
thecrypticace Jan 21, 2022
e22fa5e
WIP groups
thecrypticace Jan 21, 2022
a251134
Add static search filtering to combobox
thecrypticace Jan 21, 2022
de0211a
Move mouse leave event to combobox
thecrypticace Jan 21, 2022
1e99d62
Fix use in fragments
thecrypticace Jan 21, 2022
0817e88
Update
thecrypticace Jan 21, 2022
da3c230
WIP
RobinMalfait Jan 24, 2022
ae9ebb7
make all tests pass for the combobox in React
RobinMalfait Jan 25, 2022
44ccc49
remove unnecessary playground item
RobinMalfait Jan 25, 2022
956d850
remove listbox wip
RobinMalfait Jan 25, 2022
3ff184b
only fire change event on inputs
RobinMalfait Jan 25, 2022
910ffe1
disable combobox vue tests
RobinMalfait Jan 25, 2022
9b867ef
Fix vue typescript errors
thecrypticace Jan 25, 2022
e30b623
Vue tests WIP
thecrypticace Jan 26, 2022
fbd589c
improve combobox playgrounds a tiny bit
RobinMalfait Jan 26, 2022
d306e07
ensure to lookup the correct value
RobinMalfait Jan 26, 2022
f9e8421
make sure that we are using a div instead of a Fragment
RobinMalfait Jan 26, 2022
a1e1bbf
expose `activeItem`
RobinMalfait Jan 26, 2022
deaec8c
Update comments
thecrypticace Jan 26, 2022
02a8a28
Port react tests to Vue
thecrypticace Jan 26, 2022
f2e2fe8
Vue tests WIP
thecrypticace Jan 26, 2022
266c9b7
WIP
thecrypticace Jan 26, 2022
38008e1
Rename activeItem to activeOption
thecrypticace Jan 26, 2022
734a88d
Move display value to input
thecrypticace Jan 26, 2022
aa8538d
Update playgrounds
thecrypticace Jan 26, 2022
32867af
Remove static filtering
thecrypticace Jan 26, 2022
d56fdea
Add tests for display value
thecrypticace Jan 26, 2022
cfbc1a3
WIP Vue Tests
thecrypticace Jan 26, 2022
60b67c1
WIP
thecrypticace Jan 26, 2022
d9d2b45
unfocus suite
thecrypticace Jan 26, 2022
ec54851
Cleanup react accessibility assertions code
thecrypticace Jan 26, 2022
cc05d6e
Vue WIP
thecrypticace Jan 26, 2022
1947020
Cleanup errors in react interactions test utils
thecrypticace Jan 26, 2022
f2f0e1a
Update vue implementation
thecrypticace Jan 26, 2022
d7062b8
Fix searching
thecrypticace Jan 26, 2022
50d2a20
Update
thecrypticace Jan 26, 2022
e69107e
Add display value stubs
thecrypticace Jan 26, 2022
b06000d
Update tests
thecrypticace Jan 26, 2022
10aa2b1
move `<Combobox onSearch={} />` to `<Combobox.Input onChange={} />`
RobinMalfait Jan 27, 2022
947e03e
use `useLatestValue` hook
RobinMalfait Jan 27, 2022
afb18a0
make `onChange` explicitly required
RobinMalfait Jan 27, 2022
447baad
remove unused variables
RobinMalfait Jan 27, 2022
c0f7bfe
move `<Combobox @search="" />` to `<ComboboxInput @change="" />`
RobinMalfait Jan 27, 2022
c35a585
use correct event
RobinMalfait Jan 27, 2022
bbb2054
use `let` for consistency
RobinMalfait Jan 27, 2022
bef1af3
remove unnecessary hidden check
RobinMalfait Jan 27, 2022
f2fe19b
implement displayValue for Vue
RobinMalfait Jan 27, 2022
bcf8a23
update playground to reflect changes
RobinMalfait Jan 27, 2022
b22fdff
make sure that the activeOptionIndex stays correct
RobinMalfait Jan 27, 2022
3e5fc4f
update changelog
RobinMalfait Jan 27, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improve controlled Tabs behaviour ([#1050](https://github.com/tailwindlabs/headlessui/pull/1050))
- Improve typeahead search logic ([#1051](https://github.com/tailwindlabs/headlessui/pull/1051))

### Added

- Add `Combobox` component ([#1047](https://github.com/tailwindlabs/headlessui/pull/1047))

## [Unreleased - @headlessui/vue]

### Fixed

- Ensure correct order when conditionally rendering `MenuItem`, `ListboxOption` and `RadioGroupOption` ([#1045](https://github.com/tailwindlabs/headlessui/pull/1045))
- Improve typeahead search logic ([#1051](https://github.com/tailwindlabs/headlessui/pull/1051))

### Added

- Add `Combobox` component ([#1047](https://github.com/tailwindlabs/headlessui/pull/1047))

## [@headlessui/react@v1.4.3] - 2022-01-14

### Fixes
Expand Down Expand Up @@ -88,7 +96,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add `aria-orientation` to `Listbox`, which swaps Up/Down with Left/Right keys ([#683](https://github.com/tailwindlabs/headlessui/pull/683))
- Expose `close` function from the render prop for `Disclosure`, `Disclosure.Panel`, `Popover` and `Popover.Panel` ([#697](https://github.com/tailwindlabs/headlessui/pull/697))


## [@headlessui/vue@v1.4.0] - 2021-07-29

### Added
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
],
"scripts": {
"react": "yarn workspace @headlessui/react",
"react-playground": "yarn workspace playground-react dev",
"playground-react": "yarn workspace playground-react dev",
"vue": "yarn workspace @headlessui/vue",
"shared": "yarn workspace @headlessui/shared",
"build": "yarn workspaces run build",
Expand Down
1 change: 1 addition & 0 deletions packages/@headlessui-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"prepublishOnly": "npm run build",
"test": "../../scripts/test.sh",
"build": "../../scripts/build.sh",
"watch": "../../scripts/watch.sh",
"lint": "../../scripts/lint.sh"
},
"peerDependencies": {
Expand Down
Loading