Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FocusTrap in Dialog when there is only 1 focusable element #2172

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Fix FocusTrap in Dialog when there is only 1 focusable element #2172

merged 3 commits into from
Jan 25, 2023

Commits on Jan 25, 2023

  1. add tests to guarantee FocusTrap with a single element works as exp… 

    …ected
    @RobinMalfait
    RobinMalfait committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    88e745f View commit details
    Browse the repository at this point in the history

  2. it should keep the focus in the Dialog 

    Even if there is only 1 element. We were skipping the current active
element so the container didn't have any elements anymore and just
continued to the next focusable element in line. This will prevent that
and ensure that we can only skip elements if there are multiple ones.
    @RobinMalfait
    RobinMalfait committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    6cb3ff2 View commit details
    Browse the repository at this point in the history

  3. update changelog

    @RobinMalfait
    RobinMalfait committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    68c6e7a View commit details
    Browse the repository at this point in the history