Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when reading headlessuiFocusGuard of relatedTarget in the FocusTrap component #2203

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Fix crash when reading headlessuiFocusGuard of relatedTarget in the FocusTrap component #2203

merged 2 commits into from
Jan 24, 2023

Commits on Jan 24, 2023

  1. ensure relatedTarget is an HTMLElement 

    Or in other words, Robin trust the type system...

I was assuming that this was always an `HTMLElement` or `null` but
that's not the case. Just using `e.relatedTarget` shows that `dataset`
is not always available.
    @RobinMalfait
    RobinMalfait committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6b00b96 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1e35d59 View commit details
    Browse the repository at this point in the history