Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PopoverOverlay to PopoverBackdrop #3308

Merged
merged 3 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@headlessui-react/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add CSS based transitions using `data-*` attributes ([#3273](https://github.com/tailwindlabs/headlessui/pull/3273), [#3285](https://github.com/tailwindlabs/headlessui/pull/3285))
- Add a `transition` prop to `<Dialog />` component ([#3307](https://github.com/tailwindlabs/headlessui/pull/3307))
- Re-introduce `<DialogBackdrop />` component ([#3307](https://github.com/tailwindlabs/headlessui/pull/3307))
- Added `PopoverBackdrop` component to replace `PopoverOverlay` ([#3308](https://github.com/tailwindlabs/headlessui/pull/3308))

### Fixed

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Next.js barrel file improvements (GENERATED FILE)
export type * from '../popover/popover'
export { PopoverBackdrop } from '../popover/popover'
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ describe('Safe guards', () => {
it.each([
['Popover.Button', Popover.Button],
['Popover.Panel', Popover.Panel],
['Popover.Overlay', Popover.Overlay],
['Popover.Backdrop', Popover.Backdrop],
['Popover.Backdrop', Popover.Overlay],
])(
'should error when we are using a <%s /> without a parent <Popover />',
suppressConsoleLogs((name, Component) => {
Expand Down
59 changes: 35 additions & 24 deletions packages/@headlessui-react/src/components/popover/popover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -724,35 +724,42 @@ function ButtonFn<TTag extends ElementType = typeof DEFAULT_BUTTON_TAG>(

// ---

let DEFAULT_OVERLAY_TAG = 'div' as const
type OverlayRenderPropArg = {
let DEFAULT_BACKDROP_TAG = 'div' as const
type BackdropRenderPropArg = {
open: boolean
} & TransitionData
type OverlayPropsWeControl = 'aria-hidden'
type BackdropPropsWeControl = 'aria-hidden'

let OverlayRenderFeatures = RenderFeatures.RenderStrategy | RenderFeatures.Static
let BackdropRenderFeatures = RenderFeatures.RenderStrategy | RenderFeatures.Static

export type PopoverOverlayProps<TTag extends ElementType = typeof DEFAULT_OVERLAY_TAG> = Props<
export type PopoverBackdropProps<TTag extends ElementType = typeof DEFAULT_BACKDROP_TAG> = Props<
TTag,
OverlayRenderPropArg,
OverlayPropsWeControl,
{ transition?: boolean } & PropsForFeatures<typeof OverlayRenderFeatures>
BackdropRenderPropArg,
BackdropPropsWeControl,
{ transition?: boolean } & PropsForFeatures<typeof BackdropRenderFeatures>
>

function OverlayFn<TTag extends ElementType = typeof DEFAULT_OVERLAY_TAG>(
props: PopoverOverlayProps<TTag>,
export type PopoverOverlayProps<TTag extends ElementType = typeof DEFAULT_BACKDROP_TAG> =
PopoverBackdropProps<TTag>

function BackdropFn<TTag extends ElementType = typeof DEFAULT_BACKDROP_TAG>(
props: PopoverBackdropProps<TTag>,
ref: Ref<HTMLElement>
) {
let internalId = useId()
let { id = `headlessui-popover-overlay-${internalId}`, transition = false, ...theirProps } = props
let [{ popoverState }, dispatch] = usePopoverContext('Popover.Overlay')
let internalOverlayRef = useRef<HTMLElement | null>(null)
let overlayRef = useSyncRefs(ref, internalOverlayRef)
let {
id = `headlessui-popover-backdrop-${internalId}`,
transition = false,
...theirProps
} = props
let [{ popoverState }, dispatch] = usePopoverContext('Popover.Backdrop')
let internalBackdropRef = useRef<HTMLElement | null>(null)
let backdropRef = useSyncRefs(ref, internalBackdropRef)

let usesOpenClosedState = useOpenClosed()
let [visible, transitionData] = useTransition(
transition,
internalOverlayRef,
internalBackdropRef,
usesOpenClosedState !== null
? (usesOpenClosedState & State.Open) === State.Open
: popoverState === PopoverStates.Open
Expand All @@ -767,11 +774,11 @@ function OverlayFn<TTag extends ElementType = typeof DEFAULT_OVERLAY_TAG>(
return {
open: popoverState === PopoverStates.Open,
...transitionData,
} satisfies OverlayRenderPropArg
} satisfies BackdropRenderPropArg
}, [popoverState, transitionData])

let ourProps = {
ref: overlayRef,
ref: backdropRef,
id,
'aria-hidden': true,
onClick: handleClick,
Expand All @@ -781,10 +788,10 @@ function OverlayFn<TTag extends ElementType = typeof DEFAULT_OVERLAY_TAG>(
ourProps,
theirProps,
slot,
defaultTag: DEFAULT_OVERLAY_TAG,
features: OverlayRenderFeatures,
defaultTag: DEFAULT_BACKDROP_TAG,
features: BackdropRenderFeatures,
visible,
name: 'Popover.Overlay',
name: 'Popover.Backdrop',
})
}

Expand Down Expand Up @@ -1187,9 +1194,9 @@ export interface _internal_ComponentPopoverButton extends HasDisplayName {
): JSX.Element
}

export interface _internal_ComponentPopoverOverlay extends HasDisplayName {
<TTag extends ElementType = typeof DEFAULT_OVERLAY_TAG>(
props: PopoverOverlayProps<TTag> & RefProp<typeof OverlayFn>
export interface _internal_ComponentPopoverBackdrop extends HasDisplayName {
<TTag extends ElementType = typeof DEFAULT_BACKDROP_TAG>(
props: PopoverBackdropProps<TTag> & RefProp<typeof BackdropFn>
): JSX.Element
}

Expand All @@ -1207,13 +1214,17 @@ export interface _internal_ComponentPopoverGroup extends HasDisplayName {

let PopoverRoot = forwardRefWithAs(PopoverFn) as _internal_ComponentPopover
export let PopoverButton = forwardRefWithAs(ButtonFn) as _internal_ComponentPopoverButton
export let PopoverOverlay = forwardRefWithAs(OverlayFn) as _internal_ComponentPopoverOverlay
/** @deprecated use `<PopoverBackdrop>` instead of `<PopoverOverlay>` */
export let PopoverOverlay = forwardRefWithAs(BackdropFn) as _internal_ComponentPopoverBackdrop
export let PopoverBackdrop = forwardRefWithAs(BackdropFn) as _internal_ComponentPopoverBackdrop
export let PopoverPanel = forwardRefWithAs(PanelFn) as _internal_ComponentPopoverPanel
export let PopoverGroup = forwardRefWithAs(GroupFn) as _internal_ComponentPopoverGroup

export let Popover = Object.assign(PopoverRoot, {
/** @deprecated use `<PopoverButton>` instead of `<Popover.Button>` */
Button: PopoverButton,
/** @deprecated use `<PopoverBackdrop>` instead of `<Popover.Backdrop>` */
Backdrop: PopoverBackdrop,
/** @deprecated use `<PopoverOverlay>` instead of `<Popover.Overlay>` */
Overlay: PopoverOverlay,
/** @deprecated use `<PopoverPanel>` instead of `<Popover.Panel>` */
Expand Down
1 change: 1 addition & 0 deletions packages/@headlessui-react/src/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ it('should expose the correct components', () => {
'MenuSeparator',

'Popover',
'PopoverBackdrop',
'PopoverButton',
'PopoverGroup',
'PopoverOverlay',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1326,7 +1326,7 @@ export function getPopoverPanel(): HTMLElement | null {
}

export function getPopoverOverlay(): HTMLElement | null {
return document.querySelector('[id^="headlessui-popover-overlay-"]')
return document.querySelector('[id^="headlessui-popover-backdrop-"]')
}

// ---
Expand Down
Loading