-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add size-*
shorthand
#12287
Merged
Merged
Add size-*
shorthand
#12287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add plugin tests Adjust options wip
jrysana
reviewed
Oct 25, 2023
thecrypticace
added a commit
that referenced
this pull request
Dec 4, 2023
thecrypticace
added a commit
that referenced
this pull request
Dec 5, 2023
thecrypticace
added a commit
that referenced
this pull request
Dec 18, 2023
18 tasks
ArnaudBarre
reviewed
Dec 22, 2023
@@ -968,6 +968,40 @@ module.exports = { | |||
'3/4': '75%', | |||
full: '100%', | |||
}), | |||
size: ({ theme }) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: seems like the alphabetical order was not respected
Cool! But why not a shorthand for |
@thecrypticace why were the aforementioned exceptions excluded? |
This was referenced May 19, 2024
This was referenced Jul 27, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
size-*
utility that sets bothwidth
andheight
.The supported values are the same as the
w-*
andh-*
utilities with the exception of screen units (screen
,svh
,lvh
,dvh
,svw
,lvw
, anddvw
).Now you can write this:
And it will generate the following css: