fix(corePlugins): more browser compatibility for rtl/ltr #12895
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose an improvement to the
rtl/ltr
core plugin that addresses compatibility issues on certain browsers and devices.Current Issue:
The existing implementation uses the
:where
CSS selector to achieve bidirectionality support. While this approach offers certain advantages, it has limited browser compatibility, particularly on iPhone devices before September 2020. This can cause layout and rendering problems for users on these browsers.Proposed Solution:
I propose replacing the
:where
selector with the[dir="ltr"]
selector. This alternative:Benefits:
By adopting this change, we can:
Testing:
I have thoroughly tested this change on various browsers and devices.
These tests confirm that the
[dir="rtl"]
selector functions as expected and addresses the compatibility issues associated with:where
.Request:
I kindly request that you review my proposed change and consider merging this pull request to improve the plugin's compatibility and user experience. I am confident that this modification will have a positive impact on the project and its users.
Thank you for your time and consideration.