Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining text-decoration utilities #6004

Merged
merged 6 commits into from
Nov 24, 2021
Merged

Add remaining text-decoration utilities #6004

merged 6 commits into from
Nov 24, 2021

Conversation

xiBread
Copy link
Contributor

@xiBread xiBread commented Nov 7, 2021

Continuation of #5970.

Adds utilities for:

For consistency, I've added the decoration prefix to the existing text-decoration class names and marked the old ones as deprecated aliases.

I've also deprecated decoration-slice and decoration-clone in favor of box-decoration-* to avoid ambiguity.

@adamwathan
Copy link
Member

Thanks! Need to do a bit more massaging then will explain the changes I'd like to make, but would be great to get this in for v3.

@adamwathan
Copy link
Member

Things I've tweaked before merging:

  • Don't deprecate/rename underline and related utilities, I understand the desire for consistency here but I don't think the value outweighs the cost since these are commonly used, referenced in blog posts, tutorials, etc.
  • Remove text-underline-position utilities, this seems to have questionable browser support and would require a lot of investigation to know exactly what we should support for sure — can always add this in the future when have more time to really understand the support
  • Remove DEFAULT values for thickness/underline-offset — I think a utility just called decoration adding a 1px underline isn't super clear, to me it is logical for borders but not as much here, same thinking for underline-offset as a utility
  • Add auto and from-font values to thickness utility — just added these for completion's sake + responsive undoability
  • Add auto to underline-offset utility — for undoability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants