Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foo-[abc]/[def] not being handled correctly #9866

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

RobinMalfait
Copy link
Member

This commit does a bit of cleanup, it also ensures that we lookup [abc]/[def] in the values first, and if it doesn't exist, then we start parsing all the values out.

We also ensure that abc and def are parsed out correctly for the correct type instead of dropping the rule altogether because we happen to end up with an any rule.

This commit does a bit of cleanup, it also ensures that we lookup
`[abc]/[def]` in the `values` first, and if it doesn't exist, then we
start parsing all the values out.

We also ensure that `abc` and `def` are parsed out correctly for the
correct type instead of dropping the rule altogether because we happen
to end up with an `any` rule.

TODO: we should further clean the whole type system because this should
only be used to figure out what type an arbitrary value is and to find
the corresponding plugin and that's it.
One of the fixes is doing a crazy lookup and running a generator, even
though we know it is a lookup value so we should be done with all the
work anyways.
@RobinMalfait RobinMalfait merged commit 8b44717 into master Nov 17, 2022
@RobinMalfait RobinMalfait deleted the fix/arbitrary-values-and-modifiers branch November 17, 2022 16:53
@RobinMalfait RobinMalfait changed the title Fix foo-[abc]/[def] not being handled correctl Fix foo-[abc]/[def] not being handled correctly Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant