Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash kernel on binder #95

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Conversation

mwouts
Copy link
Contributor

@mwouts mwouts commented Sep 4, 2019

Hello @takluyver ,

Thank you for the Bash Kernel, I find it so useful to share or demo bash scripts!

Would you like to provide a link to a binder with the bash_kernel? This is what this PR does.

The link in the README will work only once this PR is merged. Meanwhile you can test it at
https://mybinder.org/v2/gh/mwouts/bash_kernel/bash_kernel_on_binder

If you like we could also think of

  • documenting how to do this in the README
  • adding jupytext to binder/requirements.txt to allow Jupyter to open .sh files as Bash notebooks

Let me know what you think,

Marc

@kozo2 kozo2 mentioned this pull request Jan 27, 2020
@kdm9
Copy link
Collaborator

kdm9 commented Aug 24, 2022

Hi @mwouts, I've recently taken on co-maintaining bash_kernel, and I'm currently closing all old/stale issues and PRs.

Does this PR still work with the latest version of binder? I don't use binder myself so I have no idea. If this is still both functional and useful, I'd be happy to merge it (unless @takluyver objects).

If this isn't useful any more, let me know and I'll close it (or you can)

binder/postBuild Show resolved Hide resolved
@mwouts
Copy link
Contributor Author

mwouts commented Aug 25, 2022

Hi @kdm9 , yes I expect this PR to work with the latest version of bash_kernel.

The simplest way to test this assumption would be to rebase the branch and then click on the link https://mybinder.org/v2/gh/mwouts/bash_kernel/bash_kernel_on_binder to make sure the Bash kernel is indeed available there.

Should I do the rebase or do you want to do it yourself?

@mwouts
Copy link
Contributor Author

mwouts commented Aug 25, 2022

By the way, congratulations @kdm9 for becoming a maintainer of this project!

@kdm9
Copy link
Collaborator

kdm9 commented Aug 26, 2022

Should I do the rebase or do you want to do it yourself?

If you could, please do it yourself, as then your link above will work. I assume it wouldn't if I did it as it would be in this repo.

@mwouts
Copy link
Contributor Author

mwouts commented Aug 26, 2022

Hi @kdm9 , I've just done the merge with the main branch so this PR is up to date.

I confirm the binder link still works (https://mybinder.org/v2/gh/mwouts/bash_kernel/bash_kernel_on_binder for this PR, will be https://mybinder.org/v2/gh/takluyver/bash_kernel/master in README.rst).

Here is a screenshot of Binder with the Bash kernel available:
image

@kdm9
Copy link
Collaborator

kdm9 commented Aug 26, 2022

Niiiice :)

Thanks a bunch @mwouts . I'm happy to merge then.

@takluyver I'll merge this later today unless I hear any objection as I think you've seen this already since you commented up thread. Or just hit the button yourself of course :)

@takluyver
Copy link
Owner

Nothing I like better than pressing buttons - thanks for getting things moving again.

I suppose we could also think about having a brief demo notebook in the repository to give people something to look at on Binder.

@takluyver takluyver merged commit 6a7aaf2 into takluyver:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants