fix(index): fix decode handle #65

taoyq1988 · 2020-12-17T06:27:47Z

if index value is not exist, will make session panic for decode handle

CLAassistant · 2020-12-17T06:27:53Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

winoros · 2021-01-19T05:47:30Z

table/tables/index.go

@@ -41,6 +41,9 @@ func EncodeHandle(h int64) []byte {

 // DecodeHandle decodes handle in data.
 func DecodeHandle(data []byte) (int64, error) {
+	if len(data) < 8 {
+		return 0, nil


Please return error instead.

winoros reviewed Jan 19, 2021

View reviewed changes

fix(index): fix decode handle

0186519

taoyq1988 force-pushed the fix-handle branch from 7756f5e to 0186519 Compare July 20, 2022 11:17

taoyq1988 requested a review from yanguwan July 20, 2022 11:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(index): fix decode handle #65

fix(index): fix decode handle #65

taoyq1988 commented Dec 17, 2020

CLAassistant commented Dec 17, 2020

winoros Jan 19, 2021

yanguwan Jul 20, 2022

fix(index): fix decode handle #65

Are you sure you want to change the base?

fix(index): fix decode handle #65

Conversation

taoyq1988 commented Dec 17, 2020

CLAassistant commented Dec 17, 2020

winoros Jan 19, 2021

Choose a reason for hiding this comment

yanguwan Jul 20, 2022

Choose a reason for hiding this comment