merger: don't create key_def/merger for one source #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
approved these changes
Oct 19, 2021
|
typo: hehaviour -> behaviour typo: opmimization -> optimization |
|
We definitely need a performance regression test that allow us to avoid degradation in the future. If I get it right, we will address it in #225. Right? |
Totktonada
force-pushed
the
Totktonada/skip-merger-creation-for-one-replicaset
branch
from
6304b54
to
f7173b9
Compare
|
Fixed typos. |
A merge source has the same API as merger itself, so there is no difference in behaviour between a merger created from one source and this source itself. However there is no overhead for creating key_def, merger and passing tuples over the merger. This optimization gives me 13% boost on the case from #220. Follows up #220
Totktonada
force-pushed
the
Totktonada/skip-merger-creation-for-one-replicaset
branch
from
f7173b9
to
54171b7
Compare
Totktonada
deleted the
Totktonada/skip-merger-creation-for-one-replicaset
branch
This was referenced Nov 11, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A merge source has the same API as merger itself, so there is no
difference in behaviour between a merger created from one source and
this source itself. However there is no overhead for creating key_def,
merger and passing tuples over the merger.
This optimization gives me 13% boost on the case from #220.
Follows up #220
There is no simple way to check it with a test, so I skipped it. Hopefully we'll see a difference after #225. I tested the patch manually for now.