Optimize select with known bucket_id #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
changed the title
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-234-optimize-know-bucket_id
branch
from
ae0885c
to
4e14f6a
Compare
DifferentialOrange
changed the base branch from
master
to
DifferentialOrange/gh-225-vshard-performance
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-225-vshard-performance
branch
from
21420dd
to
10733cb
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-234-optimize-know-bucket_id
branch
from
4e14f6a
to
a26dbea
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-225-vshard-performance
branch
from
10733cb
to
859a624
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-234-optimize-know-bucket_id
branch
from
a26dbea
to
2e36906
Compare
|
The implemented optimization looks okay, but I had idea to find more headrooms in the scope of the issue. Are you plan to do so? |
I thought the plan was only to solve this one and investigate code later as part of some another ticket/epic. |
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-225-vshard-performance
branch
2 times, most recently
from
efae10e
to
920523e
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-234-optimize-know-bucket_id
branch
2 times, most recently
from
949bd39
to
fc2e693
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-225-vshard-performance
branch
2 times, most recently
from
fc249e9
to
3c53164
Compare
Base automatically changed from
DifferentialOrange/gh-225-vshard-performance
to
master
March 4, 2022 13:47
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-234-optimize-know-bucket_id
branch
from
fc2e693
to
6c0f17a
Compare
After this patch, select and pairs requests will no longer fetch sharding key info and extract sharding key info if bucket_id specified. Since calls with specified bucket_id already ignore sharding key values, behavior will not change. Other crud operations already have this optimization. Based on test runs on HP ProBook 440 G7 i7/16Gb, performance had increased by 6-7%. Part of #234
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-234-optimize-know-bucket_id
branch
from
6c0f17a
to
7146f59
Compare
DifferentialOrange
deleted the
DifferentialOrange/gh-234-optimize-know-bucket_id
branch
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #251.
After this patch, select and pairs requests will no longer fetch
sharding key info and extract sharding key info if bucket_id specified.
Since calls with specified bucket_id already ignore sharding key
values, behavior will not change. Other crud operations already have
this optimization.
Based on test runs on HP ProBook 440 G7 i7/16Gb, performance had
increased by 6-7%.
I didn't forget about
Part of #234