cfg: fix losing stats parameter on update #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, stats_quantile_tolerated_error configuration parameter value could be lost in the following sequence of separate crud.cfg calls: 1. Set up stats_quantile_tolerated_error (maybe together with other parameters). 2. Set up any other cfg parameter, do not set stats_quantile_tolerated_error in call explicitly. It was expected that stats_quantile_tolerated_error from the first step will be preserved after the second one, but it was lost. This patch fixes the behavior. Follows up PR #281, closes #284
3 tasks
Totktonada
approved these changes
May 17, 2022
DifferentialOrange
deleted the
DifferentialOrange/gh-284-tolerated-error-lost
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, stats_quantile_tolerated_error configuration
parameter value could be lost in the following sequence of separate
crud.cfg calls:
parameters).
stats_quantile_tolerated_error in call explicitly.
It was expected that stats_quantile_tolerated_error from the first step
will be preserved after the second one, but it was lost. This patch
fixes the behavior.
I didn't forget about
Follows up PR #281, closes #284