Return the new configuration on `require('config'):get()` in the role. #9649

ImeevMA · 2024-02-05T13:47:17Z

Currently, require('config'):get() throws an error if executed in a role that is applied at config startup. If require('config'):get() is executed in a role that is applied at config reload, it returns the previous configuration.

The expected behavior is to return the configuration that is currently applied.

The text was updated successfully, but these errors were encountered:

Roles are now started and stopped at the "post_apply" stage rather than at the "apply" stage. This allows require('config'):get() to correctly return the configuration that is being applied. Closes tarantool#9649 NO_DOC=bugfix

Roles are now started and stopped at the "post_apply" stage rather than at the "apply" stage. This allows require('config'):get() to correctly return the configuration that is being applied. Closes #9649 NO_DOC=bugfix

Roles are now started and stopped at the "post_apply" stage rather than at the "apply" stage. This allows require('config'):get() to correctly return the configuration that is being applied. Closes tarantool#9649 NO_DOC=bugfix (cherry picked from commit ebb170c)

Roles are now started and stopped at the "post_apply" stage rather than at the "apply" stage. This allows require('config'):get() to correctly return the configuration that is being applied. Closes #9649 NO_DOC=bugfix (cherry picked from commit ebb170c)

This patch introduce basic crud-router and crud-storage roles for Tarantool 3. The roles are similar to Cartridge ones. Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2]. This commit does not yet introduce metrics configuration through roles config. [1] tarantool/tarantool#9643 [2] tarantool/tarantool#9649 Part of #415

This patch introduce basic crud-router and crud-storage roles for Tarantool 3. The roles are similar to Cartridge ones. Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2]. This commit makes all existing config tests run with roles enabled instead of manual bootstrap. This commit does not yet introduce metrics configuration through roles config. [1] tarantool/tarantool#9643 [2] tarantool/tarantool#9649 Part of #415

ImeevMA added bug Something isn't working config labels Feb 5, 2024

ImeevMA self-assigned this Feb 5, 2024

ImeevMA mentioned this issue Feb 5, 2024

config: move role start and stop to _post_apply() #9651

Merged

Totktonada added the 3.0 Target is 3.0 and all newer release/master branches label Feb 6, 2024

Totktonada closed this as completed in #9651 Feb 7, 2024

Totktonada mentioned this issue Feb 7, 2024

[backport 3.0] config: move role start and stop to _post_apply() #9660

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return the new configuration on `require('config'):get()` in the role. #9649

Return the new configuration on `require('config'):get()` in the role. #9649

ImeevMA commented Feb 5, 2024

Return the new configuration on require('config'):get() in the role. #9649

Return the new configuration on require('config'):get() in the role. #9649

Comments

ImeevMA commented Feb 5, 2024

Return the new configuration on `require('config'):get()` in the role. #9649

Return the new configuration on `require('config'):get()` in the role. #9649