Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial num-traits support #80

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Add initial num-traits support #80

merged 1 commit into from
Apr 24, 2021

Conversation

tarcieri
Copy link
Owner

@tarcieri tarcieri commented Apr 24, 2021

Adds a conditional impl of the Num trait for F32, gated on the num-traits feature.

Closes #57.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2021

Codecov Report

Merging #80 (766f67f) into main (b7f6919) will decrease coverage by 0.73%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   61.04%   60.31%   -0.74%     
==========================================
  Files          38       38              
  Lines         824      834      +10     
==========================================
  Hits          503      503              
- Misses        321      331      +10     
Impacted Files Coverage Δ
src/float.rs 51.79% <0.00%> (-4.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f6919...766f67f. Read the comment docs.

Adds a conditional impl of the `Num` trait for `F32`, gated on the
`num-traits` feature.
@tarcieri tarcieri merged commit 3942444 into main Apr 24, 2021
@tarcieri tarcieri deleted the num-traits branch April 24, 2021 20:24
@tarcieri tarcieri mentioned this pull request Apr 25, 2021
@tarcieri tarcieri mentioned this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with num-traits
2 participants