Skip to content

Commit

Permalink
deps: V8: cherry-pick 166fd2f38f44
Browse files Browse the repository at this point in the history
Original commit message:

    [cppgc]: Fix build on msvc
    Fixes compilation with msvc 2019 toolchain.

    See: nodejs#37330 (comment)

    Bug: v8:12661
    Change-Id: I7cfd87a3dd531a2e4913d82b743fb8ecdfdb5ed8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3533019
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#85087}

Refs: v8/v8@166fd2f
  • Loading branch information
targos committed Jan 11, 2023
1 parent 993c6ed commit 8ece34b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.2',
'v8_embedder_string': '-node.3',

##### V8 defaults for Node.js #####

Expand Down
9 changes: 9 additions & 0 deletions deps/v8/include/v8-cppgc.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ struct WrapperDescriptor final {
};

struct V8_EXPORT CppHeapCreateParams {
CppHeapCreateParams(
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces,
WrapperDescriptor wrapper_descriptor)
: custom_spaces(std::move(custom_spaces)),
wrapper_descriptor(wrapper_descriptor) {}

CppHeapCreateParams(const CppHeapCreateParams&) = delete;
CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete;

std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
WrapperDescriptor wrapper_descriptor;
/**
Expand Down

0 comments on commit 8ece34b

Please sign in to comment.