Skip to content

Commit

Permalink
build: re-enable V8 concurrent marking
Browse files Browse the repository at this point in the history
It was unintentionally disabled during a V8 update.

Fixes: nodejs#41012
  • Loading branch information
targos committed Dec 5, 2021
1 parent 147d23b commit bbcf7be
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
16 changes: 16 additions & 0 deletions tools/v8_gypfiles/features.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,16 @@
# Sets -dV8_TRACE_FEEDBACK_UPDATES.
'v8_enable_trace_feedback_updates%': 0,

# Sets -dV8_ATOMIC_OBJECT_FIELD_WRITES and turns all field write operations
# into relaxed atomic operations.
'v8_enable_atomic_object_field_writes%': 1,

# Sets -dV8_ATOMIC_MARKING_STATE
'v8_enable_atomic_marking_state%': 1,

# Has no effect in Node.js. Here for completeness with V8's config.
'v8_enable_concurrent_marking%': 1,

# Enables various testing features.
'v8_enable_test_features%': 0,

Expand Down Expand Up @@ -343,6 +353,12 @@
['v8_enable_third_party_heap==1', {
'defines': ['V8_ENABLE_THIRD_PARTY_HEAP',],
}],
['v8_enable_atomic_object_field_writes==1', {
'defines': ['V8_ATOMIC_OBJECT_FIELD_WRITES',],
}],
['v8_enable_atomic_marking_state==1', {
'defines': ['V8_ATOMIC_MARKING_STATE',],
}],
['v8_enable_lazy_source_positions==1', {
'defines': ['V8_ENABLE_LAZY_SOURCE_POSITIONS',],
}],
Expand Down
9 changes: 3 additions & 6 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1713,12 +1713,9 @@
'is_ubsan_vptr=0',
'target_cpu=<(target_arch)',
'v8_current_cpu=<(v8_current_cpu)',
# Not available in gyp.
'v8_enable_atomic_marking_state=0',
# Not available in gyp.
'v8_enable_atomic_object_field_writes=0',
# Not available in gyp.
'v8_enable_concurrent_marking=0',
'v8_enable_atomic_marking_state=<(v8_enable_atomic_marking_state)',
'v8_enable_atomic_object_field_writes=<(v8_enable_atomic_object_field_writes)',
'v8_enable_concurrent_marking=<(v8_enable_concurrent_marking)',
'v8_enable_i18n_support=<(v8_enable_i18n_support)',
'v8_enable_verify_predictable=<(v8_enable_verify_predictable)',
'v8_enable_verify_csa=<(v8_enable_verify_csa)',
Expand Down

0 comments on commit bbcf7be

Please sign in to comment.