Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable rust #47

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Stable rust #47

merged 2 commits into from
Jul 2, 2021

Conversation

CjS77
Copy link
Contributor

@CjS77 CjS77 commented Jul 2, 2021

Updated dependencies such that Rust stable 1.53 is now supported.

The optimised avx_2 option will NOT run on stable because there's still an unstable feature on subtle-ng. BUT this feature is actually for doc generation and has been removed from Rust. As soon as subtle-ng
merges dalek-cryptography/subtle#85,avx2 will probably be supported on stable as well.

  • Update benchmark code to use new dependency APIs
  • Run rust-fmt

delta1
delta1 previously approved these changes Jul 2, 2021
Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, untested

CjS77 added 2 commits July 2, 2021 15:07
Updated dependencies such that Rust stable 1.53 is now supported.
The optimised avx_2 option will NOT rust on stable because there's
still an unstable feature on subtle-ng. BUT this feature is actually
for doc generation and has been removed from Rust. As soon as subtle-ng
merges dalek-cryptography/subtle#85, avx2 will
probably be supported on stable as well.

The rand dep update breaks the benchmarks, but these will be fixed in
the next commit.
* Update benchmark code to use new dependency APIs
* Run rust-fmt
@CjS77 CjS77 merged commit dd05268 into main Jul 2, 2021
@CjS77 CjS77 deleted the stable_rust branch July 2, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants