-
Notifications
You must be signed in to change notification settings - Fork 215
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: ensure that features are set when syncing peers (#3745)
Description --- - updates features in peer sync when a signature is valid - invalidates the identity signature of a peer if addresses/features are changed Motivation and Context --- If a peer somehow is created with incorrect peer features (say, by adding a wallet to peer_seeds list), and that same peer is later synced with a valid signature but without updating the erroneous features in the existing peer, the peer will have an invalid state and signature in its database causing it to be banned by other nodes. How Has This Been Tested? --- Manually, added a wallet to my peer seeds and didnt get banned
- Loading branch information
Showing
3 changed files
with
35 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters