-
Notifications
You must be signed in to change notification settings - Fork 215
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: default network selection (#5333)
Description --- Features is now a frequently used build dep in most our crates. Common actually also needs to be feature aware during build time. This means tari-features should have little to no dependencies, and especially none from our own crates. Motivation and Context --- Related to issue #5326 Related to nextnet hotfix #5327 How Has This Been Tested? --- Manually What process can a PR reviewer use to test or verify this change? --- Run cargo build with the desired network type (nextnet): `TARI_NETWORK=nextnet cargo build --bin tari_base_node` Run the bin directly without using cargo. It's important not to use cargo during the testing as the bin will likely rebuild when using `run` and change the previous `TARI_NETWORK` compilation settings: `./target/tari_base_node` See that the default network is NextNet. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
- Loading branch information
Showing
5 changed files
with
29 additions
and
18 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
// Copyright 2023 The Tari Project | ||
// SPDX-License-Identifier: BSD-3-Clause | ||
|
||
use tari_features::resolver::build_features; | ||
|
||
pub fn main() { | ||
build_features(); | ||
// Build as usual | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters