fix: exclude libtor from windows build (#4631)

tari-project · Sep 8, 2022 · dffea23 · dffea23
1 parent c7c9075
commit dffea23
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/base_node_binaries.json b/.github/workflows/base_node_binaries.json
@@ -43,7 +43,8 @@
     "target": "x86_64-pc-windows-msvc",
     "cross": false,
     "target_cpu": "x86-64",
-    "features": "safe"
+    "features": "safe",
+    "flags": "--workspace --exclude tari_libtor"
   },
   {
     "name": "windows-arm64",

diff --git a/.github/workflows/base_node_binaries.yml b/.github/workflows/base_node_binaries.yml
@@ -187,7 +187,7 @@ jobs:
         with:
           use-cross: ${{ matrix.builds.cross }}
           command: build
-          args: --release --target ${{ matrix.builds.target }} --features ${{ matrix.builds.features }} ${{ matrix.builds.target_bins }} --locked
+          args: --release --target ${{ matrix.builds.target }} --features ${{ matrix.builds.features }} ${{ matrix.builds.target_bins }} ${{ matrix.builds.flags }} --locked
 
       - name: Copy binaries to folder for zipping
         shell: bash

diff --git a/infrastructure/libtor/Cargo.toml b/infrastructure/libtor/Cargo.toml
@@ -16,7 +16,4 @@ multiaddr = { version = "0.14.0" }
 rand = "0.8"
 tempfile = "3.1.0"
 tor-hash-passwd = "1.0.1"
-
-[target.'cfg(unix)'.dependencies]
-tari_shutdown = { version = "^0.38", path = "../shutdown"}
-libtor = { version = "46.9.0", optional = true }
+libtor = "46.9.0"
diff --git a/infrastructure/libtor/src/lib.rs b/infrastructure/libtor/src/lib.rs
@@ -20,5 +20,9 @@
 // WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
 // USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#[cfg(unix)]
+// For some inexplicable reason if we don't include extern crate then we get libtor not defined errors in this crate on
+// matrix builds
+#[allow(unused_extern_crates)]
+extern crate libtor;
+
 pub mod tor;