Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHT should only store valid message body hashes in the dedup cache #3419

Closed
SWvheerden opened this issue Oct 5, 2021 · 0 comments · Fixed by #4003
Closed

DHT should only store valid message body hashes in the dedup cache #3419

SWvheerden opened this issue Oct 5, 2021 · 0 comments · Fixed by #4003

Comments

@SWvheerden
Copy link
Collaborator

It is possible for a malicious node to tamper with the DHT header of a message to make the message invalid. It can then forward this message. All receiving nodes will store the message body in the dedup cache and proceed to process the message. It will then discard it, rightly so.

But when the correct message arrives with the correct header the node will discard the message because the body is already in the dedup cache making it believe it already processed the message.
@sdbondi sdbondi mentioned this issue Apr 5, 2022
Merged
stringhandler pushed a commit that referenced this issue Apr 7, 2022
@sdbondi
fix(dht): saf storage uses constructs correct msg hash (#4003)
e1e7669 
Description
---
- construct the dedup hash correctly in SAF messages
- consolidate dedup hashing
- move dedup to after decryption/validation step in saf processor

Motivation and Context
---
SAF db is also used for dedup, so the hash must match. 
Closes #3419

How Has This Been Tested?
---
Existing unit tests, memorynet and manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dht): saf storage uses constructs correct msg hash sdbondi/tari
1 participant
@SWvheerden