Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network default not loading correct config settings #4402

Closed
SWvheerden opened this issue Aug 5, 2022 · 0 comments · Fixed by #4407
Closed

Network default not loading correct config settings #4402

SWvheerden opened this issue Aug 5, 2022 · 0 comments · Fixed by #4407
Assignees

Comments

@SWvheerden
Copy link
Collaborator

If you run the base_node as cargo run --bin tari_base_node
The node will run in the default network which is Esmeralda.
But the node will not read the correct config settings from config.toml

Running the node as cargo run --bin tari_base_node -- -- network esmeralda solves this and the node reads the correct setting

stringhandler pushed a commit that referenced this issue Aug 8, 2022
Description
---
Uses `network` value from cli, config, then default (currently, Esmeralda) in that order.
The network is read from the config file before getting and applying config overrides.

Fixes #4402 

Motivation and Context
---
On the base node, the network would need to be explicitly provided on the cli for config file overrides to be applied.
The network value set in the config file was previously ignored.
The default network `Network::default()` is set in one place for every application. 

How Has This Been Tested?
---
Manually:
- not setting a network in cli on the base node and checking that esme is used
- changing network on in the config file and checking that it is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants