Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base_node sync, should remove blocks from orphan db it syncs and not leave them in the orphan db #4867

Closed
SWvheerden opened this issue Oct 28, 2022 · 0 comments · Fixed by #4868
Closed

Base_node sync, should remove blocks from orphan db it syncs and not leave them in the orphan db #4867

SWvheerden opened this issue Oct 28, 2022 · 0 comments · Fixed by #4868
Assignees
@SWvheerden

Comments

@SWvheerden
Copy link
Collaborator

base-node.zip
Kinda linked to #4866 , but not fully. As the title says block sync should clear from orphan db if they exist.

This is the example of it happening:

ERROR Failed to handle incoming block message: Comms interface error: `Chain storage error: The requested Orphan accumulated data was not found via hash:642b34efbcd590e08769219738e86cf95da2a1280be671a365ebc882c181e801 in the database
@SWvheerden SWvheerden self-assigned this Oct 28, 2022
@SWvheerden SWvheerden mentioned this issue Oct 28, 2022
Merged
stringhandler pushed a commit that referenced this issue Oct 31, 2022
@SWvheerden
fix: delete orphans if they exist (#4868)
6ff1c02 
Description
---
Orphans should be deleted from the orphan database if they exist. 

Motivation and Context
---
If the block is added to the main chain, it should not exist in the orphan database as well. It will also remove the orphan tips if it removes the block from the pool. 

How Has This Been Tested?
---
Unit test and manually running

fixes: #4867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: delete orphans if they exist SWvheerden/tari
1 participant
@SWvheerden