Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wallet] Change decrypt and encrypt methods to not mutate the object, but rather make them pure functions #5007

Closed
stringhandler opened this issue Dec 7, 2022 · 0 comments
Closed

[wallet] Change decrypt and encrypt methods to not mutate the object, but rather make them pure functions #5007

stringhandler opened this issue Dec 7, 2022 · 0 comments
Assignees
@jorgeantonio21
Milestone
Stagenet Freeze

Comments

@stringhandler
Copy link
Collaborator

No description provided.

@stringhandler stringhandler added this to the Stagenet Freeze milestone Dec 7, 2022
@jorgeantonio21 jorgeantonio21 mentioned this issue Dec 12, 2022
Merged
stringhandler pushed a commit that referenced this issue Jan 10, 2023
@jorgeantonio21
fix: functional wallet encryption (issue #5007) (#5043)
7b2311e 
Description
---
Wallet encryption and decryption is now done via pure methods, instead of mutating in place the required fields, see #5007.

Motivation and Context
---
Address issue #5007.

How Has This Been Tested?
---
Existing unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgeantonio21 jorgeantonio21

Labels
None yet
Projects
Tari Esme Testnet
Status: Done
Milestone
Stagenet Freeze
Development

No branches or pull requests
2 participants
@stringhandler @jorgeantonio21