Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet get_default_recipient_transaction should check kernel features of default transactions #5796

Closed
SWvheerden opened this issue Sep 22, 2023 · 0 comments · Fixed by #5836
Closed

wallet get_default_recipient_transaction should check kernel features of default transactions #5796

SWvheerden opened this issue Sep 22, 2023 · 0 comments · Fixed by #5836
Assignees
@brianp
Labels
release-blocker Something that needs to be fixed before a release can be made

Comments

@SWvheerden
Copy link
Collaborator

The kernel lock height should be limited to 0 for default transactions as this could cause wallets to not be able to submit transactions. This wound cause wallet to lock up funds forever as the wallet will eventually drop the transactions as the lockheights in the kernel is used to block mining of transactions and not spending.
@SWvheerden SWvheerden added the release-blocker Something that needs to be fixed before a release can be made label Sep 22, 2023
@brianp brianp mentioned this issue Oct 10, 2023
Merged
4 tasks
@brianp brianp self-assigned this Oct 10, 2023
SWvheerden pushed a commit that referenced this issue Oct 11, 2023
@brianp
fix: add lock height and kernel features checks on default transactio…
1f87226 
…ns (#5836)

Description
---
It helps to ensure the wallet doesn't end up with non-spendable inputs
preventing the ability to submit transactions.

Motivation and Context
---
Closes: #5796

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---
Double-check the spelling.

Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianp brianp

Labels
release-blocker Something that needs to be fixed before a release can be made
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add lock height and kernel features checks on default transactions brianp/tari
2 participants
@brianp @SWvheerden