Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Correct file paths #2966

Merged
merged 1 commit into from
May 25, 2021

Conversation

StriderDM
Copy link
Contributor

@StriderDM StriderDM commented May 24, 2021

Description

Correct file paths in GlobalConfig to use base_path from ConfigBootstrap instead of using current directory for relative paths in the config file.
Update gitignore

Motivation and Context

Fixes a bug where the base_path (either default or passed in as an argument) is overwritten and instead of the paths being relative to the base_path it is relative to the current executing directory.

How Has This Been Tested?

cargo run --bin tari_base_node -- --init --create_id
cargo run --bin tari_base_node 
cargo run --bin tari_base_node -- --init --create_id --base_path=$PWD/temp
cargo run --bin tari_base_node -- --base_path=$PWD/temp
cargo run --bin tari_console_wallet -- --init --create_id 
cargo run --bin tari_console_wallet
cargo run --bin tari_console_wallet  -- --init --create_id --base_path=$PWD/temp
cargo run --bin tari_console_wallet -- --base_path=$PWD/temp
cargo run --bin tari_merge_mining_proxy
cargo run --bin tari_merge_mining_proxy -- --base_path=$PWD/temp
cargo test --all

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

Update gitignore
Correct file paths in GlobalConfig to use base_path from ConfigBootstrap instead of using current directory for relative paths in the config file.
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@stringhandler stringhandler merged commit f6d7b34 into tari-project:development May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants