Fallback to default flags if rxcache initialization fails #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDM
reviewed
Jul 13, 2021
StriderDM
reviewed
Jul 13, 2021
sdbondi
force-pushed
the
core-jit-fallback
branch
4 times, most recently
from
4e5d1ad
to
098d124
Compare
- Fallback to default flags if randomx cache allocation fails. This should allow platforms with limited resources to validate blocks. Similar to how xmrig falls back: https://github.com/xmrig/xmrig/blob/02b2b87bb685ab83b132267aa3c2de0766f16b8b/src/crypto/rx/RxCache.cpp#L88 - Adds some basic unit tests - Remove unused randomx config
sdbondi
force-pushed
the
core-jit-fallback
branch
from
098d124
to
b8d8418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fallback to default flags if randomx cache allocation fails.
This should allow platforms with limited resources to validate blocks.
Similar to how xmrig falls back:
https://github.com/xmrig/xmrig/blob/02b2b87bb685ab83b132267aa3c2de0766f16b8b/src/crypto/rx/RxCache.cpp#L88
Adds some basic unit tests
Motivation and Context
A user reported "Unable to allocate randomx cache". Since this is used for block validation (not mining), falling
back to the slowest but lightest randomx profile is acceptable.
How Has This Been Tested?
Basic unit tests. Tested on weatherwax base node
Checklist:
developmentbranch.