fix: Update LibWallet recovery task event handling #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
previously approved these changes
Jul 28, 2021
|
PR queued successfully. Your position in queue is: 1 |
|
PR failed to merge with reason: Some CI status(es) failed |
|
PR queued successfully. Your position in queue is: 1 |
|
PR failed to merge with reason: Some CI status(es) failed |
The recovery task broke out of its monitoring loop before getting the `UtxoScannerEvent::Completed` event. This PR just moves that break statement so that the final completed callback is made. Also Ignore `test_store_and_forward_send_tx` due to it being flakey on CI and the functionality is covered by Cucumber tests.
philipr-za
force-pushed
the
philip-ffi-recovery
branch
from
5a55aa8
to
263e87f
Compare
stringhandler
approved these changes
Jul 28, 2021
|
PR queued successfully. Your position in queue is: 1 |
|
PR failed to merge with reason: Some CI status(es) failed |
|
PR queued successfully. Your position in queue is: 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recovery task broke out of its monitoring loop before getting the
UtxoScannerEvent::Completedevent. This PR just moves that break statement so that the final completed callback is made.How Has This Been Tested?
Wallet clients will need to test this
Checklist:
developmentbranch.