Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add timeout to protocol notifications + log improvements #3143

Merged
merged 1 commit into from
Aug 3, 2021
Merged

fix: add timeout to protocol notifications + log improvements #3143

merged 1 commit into from
Aug 3, 2021
+58 −51

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jul 28, 2021 •
edited
Loading

Description

  • protocol notifications now have a set "safety" timeout.
  • add log for inbound comms pipeline concurrency usage

Motivation and Context

Reports of inbound messaging being blocked. This will shed some light.
The logs show that a single client node is excessively trying to create multiple
t/bn-wallet//1 (rpc) sessions.

How Has This Been Tested?

Log observed in base node

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

@sdbondi sdbondi force-pushed the comms-pipeline-logging branch 5 times, most recently from dd228a0 to d01b3dd Compare July 28, 2021 12:53
@sdbondi sdbondi changed the title misc: add log for inbound comms pipeline concurrency usage fix: add timeout to protocol notifications + log improvements Jul 28, 2021
stringhandler
stringhandler previously approved these changes Jul 28, 2021
View reviewed changes
@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 28, 2021

PR queued successfully. Your position in queue is: 2

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 28, 2021

PR is on top of the queue now

@sdbondi sdbondi marked this pull request as draft July 28, 2021 13:32
@sdbondi sdbondi marked this pull request as ready for review July 28, 2021 13:32
@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 28, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 28, 2021

PR queued successfully. Your position in queue is: 2

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 28, 2021

PR is on top of the queue now

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 28, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): test

@aviator-app aviator-app bot removed the mq-failed label Jul 29, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 29, 2021

PR queued successfully. Your position in queue is: 1

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 29, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 29, 2021

PR queued successfully. Your position in queue is: 2

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 29, 2021

PR is on top of the queue now

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 29, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@aviator-app aviator-app bot removed the mq-failed label Jul 30, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 30, 2021

PR queued successfully. Your position in queue is: 1

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 30, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@sdbondi
fix: add timeout to protocol notifications + log improvements
a98a698 
- protocol notifications now have a set "safety" timeout.
- add log for inbound comms pipeline concurrency usage
@sdbondi sdbondi removed the mq-failed label Aug 2, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 2, 2021

Waiting for approval before queuing

@stringhandler stringhandler merged commit 7701846 into tari-project:development Aug 3, 2021
@sdbondi sdbondi deleted the comms-pipeline-logging branch August 4, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdbondi @stringhandler