fix(wallet): block certain keys during popup #3148

Cifko · 2021-07-30T05:37:39Z

Description

Transaction tab:

Block keys until you resolve (y)es/(n)o pop-up windows.
Esc now closes the pop-up for canceling pending transaction.

Send tab:

Block keys in send tab until you confirm the pop-up window.

Motivation and Context

There was a weird behavior, e.g. you press cancel on pending tx1, move to tx2 and press (y)es, and it delete the tx2.

How Has This Been Tested?

Manually.

Checklist:

[x] I'm merging against the development branch.
[x] I have squashed my commits into a single commit.

aviator-app · 2021-07-30T09:52:26Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T09:52:29Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T09:55:49Z

PR queued successfully. Your position in queue is: 2

aviator-app · 2021-07-30T10:20:14Z

PR is on top of the queue now

aviator-app · 2021-07-30T10:20:16Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T10:23:26Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T10:23:43Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T10:28:52Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T10:29:14Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T10:34:24Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T10:34:45Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T10:39:53Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T10:40:16Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T10:45:26Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T10:45:47Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T10:50:57Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T10:51:18Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T10:56:26Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T10:56:49Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:01:57Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:02:20Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:07:27Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:07:50Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:12:58Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:13:21Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:18:35Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:18:52Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:24:00Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:24:27Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:29:32Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:29:54Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:35:03Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:35:25Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:40:36Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:40:56Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:46:24Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:46:28Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:51:35Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:51:57Z

PR failed to merge with reason: Failed due to unknown reason
Additional debug info: Commits must have valid signatures.

aviator-app · 2021-07-30T11:57:06Z

PR queued successfully. Your position in queue is: 1

aviator-app · 2021-07-30T11:57:27Z

PR failed to merge with reason: Ready label was manually removed

aviator-app · 2021-08-04T14:26:33Z

PR queued successfully. Your position in queue is: 8

aviator-app · 2021-08-04T20:44:37Z

PR is on top of the queue now

aviator-app · 2021-08-04T21:51:47Z

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

stringhandler previously approved these changes Jul 30, 2021

View reviewed changes

stringhandler changed the title ~~fix: in wallet block certain keys during popup~~ fix(wallet): block certain keys during popup Jul 30, 2021

stringhandler added the mq-approved label Jul 30, 2021

stringhandler removed the mq-approved label Jul 30, 2021

aviator-app bot added the mq-failed label Jul 30, 2021

Cifko dismissed stringhandler’s stale review via 8291394 July 30, 2021 12:33

Cifko force-pushed the fix-wallet-cancel-transaction branch from f72656d to 8291394 Compare July 30, 2021 12:33

fix: in wallet block certain keys during popup

4a41b91

Cifko force-pushed the fix-wallet-cancel-transaction branch from 8291394 to 4a41b91 Compare August 4, 2021 13:02

stringhandler approved these changes Aug 4, 2021

View reviewed changes

stringhandler added mq-approved and removed mq-failed labels Aug 4, 2021

Merge branch 'development' into fix-wallet-cancel-transaction

994ea26

aviator-app bot added the mq-failed label Aug 4, 2021

stringhandler merged commit 8454292 into tari-project:development Aug 5, 2021

Cifko deleted the fix-wallet-cancel-transaction branch August 25, 2021 05:38

fix(wallet): block certain keys during popup #3148

fix(wallet): block certain keys during popup #3148

Conversation

Cifko commented Jul 30, 2021

Description

Motivation and Context

How Has This Been Tested?

Checklist:

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Jul 30, 2021

aviator-app bot commented Aug 4, 2021

aviator-app bot commented Aug 4, 2021

aviator-app bot commented Aug 4, 2021