Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dead_code lint error when base_node_feature is not set #3354

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Sep 16, 2021

Description

Use new_sorted_unchecked function to keep clippy happy when base_node feature is not active
in tari_core.

Motivation and Context

Causing failed CI build (e.g. #3335 )

How Has This Been Tested?

CI must pass (FFI tests)

@delta1
Copy link
Contributor

delta1 commented Sep 16, 2021

Seems fine, I went the other way in #3353 adding the base_node feature to that function - is it that an issue?

@sdbondi
Copy link
Member Author

sdbondi commented Sep 16, 2021

@delta1 Yeah I did that at first, but feels like the feature attrs are getting messier and messier. If you feel strongly one way we can close this.

@delta1
Copy link
Contributor

delta1 commented Sep 16, 2021

No I agree, I prefer this way 👍

@aviator-app aviator-app bot merged commit 7fa0572 into tari-project:development Sep 16, 2021
@sdbondi sdbondi deleted the core-dead-code branch September 16, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants