feat: allow tor proxy to be bypassed for outbound tcp connections #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `tor_proxy_bypass_for_outbound_tcp` setting that allows direct outbound connections to be made for TCP nodes, bypassing tor
sdbondi
force-pushed
the
comms-outbound-bypass-tor
branch
from
46c84d4
to
6866e42
Compare
stringhandler
approved these changes
Oct 6, 2021
|
Ah yeah sorry was a bit rushed with the description - happy to keep it like that or do you think it should be turned off? |
|
I think it's fine, but we need to add a config that can be set in the mobile apps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tor_proxy_bypass_for_outbound_tcpsetting that allows directoutbound connections to be made for TCP nodes, bypassing tor
Motivation and Context
By default, the most private mode is set and all traffic is routed through tor. With this option set
outbound tcp traffic bypasses tor for outbound TCP peer addresses in exchange for better
bandwidth and latency.
How Has This Been Tested?
Some unit tests + manually