Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add details to UnknownError #3429

Merged

Conversation

therustmonk
Copy link
Contributor

Description

This PR adds (requires) details to UnknownError.

Motivation and Context

Related to #3423
Without the fix some errors are indiscernible. Example:

     Running `target/debug/tari_base_node`
Initializing logging according to "/home/denis/.tari/config/log4rs_base_node.yml"
10:47 ERROR Network discovery errored: Connectivity error:
    Internal actor response was unexpectedly cancelled. Waiting for 5s
10:47 ERROR DhtConnectivity exited with error: ConnectivityError(ActorDisconnected)
UnknownError
10:47 ERROR Exiting with code (102): UnknownError

With the fix:

     Running `target/debug/tari_base_node`
Initializing logging according to "/home/denis/.tari/config/log4rs_base_node.yml"
10:48 ERROR Network discovery errored: Connectivity error:
    Internal actor response was unexpectedly cancelled. Waiting for 5s
UnknownError("Failed to initialize tor hidden service: TorClientError: Command failed:
    Authentication failed: Wrong length on authentication cookie.")
10:48 ERROR Exiting with code (102): UnknownError("Failed to initialize tor
    hidden service: TorClientError: Command failed: Authentication failed:
    Wrong length on authentication cookie.")

How Has This Been Tested?

Manually by activating CookieAuthentication 1 option in the Tor's settings.

@aviator-app aviator-app bot added the mq-failed label Oct 7, 2021
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviator-app aviator-app bot merged commit dddc18f into tari-project:development Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants