fix: u64->i64->u64 conversion; chain split height as u64 #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -326,15 +326,15 @@ impl tari_rpc::base_node_server::BaseNode for BaseNodeGrpcServer { | |||
|
|
|||
| let headers: Vec<u64> = if request.from_height != 0 { | |||
| match sorting { | |||
| Sorting::Desc => ((cmp::max(0, request.from_height as i64 - num_headers as i64 + 1) as u64)..= | |||
| Sorting::Desc => (cmp::max(0, request.from_height - num_headers + 1)..= | |||
There was a problem hiding this comment.
Is there not a chance for an underflow here?
There was a problem hiding this comment.
This needs a covering test, even if this logic is moved into a function.
There was a problem hiding this comment.
should this then be
let headers: Vec<u64> = if request.from_height >= num_headers {
num_headers is forced to be between 10 and 10_000
Means that from_height being 0 would go to the else
Or is it more desirable to check the underflow flag with overflowing_sub() ?
|
Seems you need to run cargo fmt |
stringhandler
approved these changes
Oct 11, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 12, 2021
* development: fix: fix confusing names in get_balance functions (tari-project#3447) feat: add sql query to obtain balance (tari-project#3446) fix: u64->i64->u64 conversion; chain split height as u64 (tari-project#3442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removing an unnecessary conversion and using u64 for chain height
How Has This Been Tested?
rust build & test