fix: minor clippy errors in comms/dht

base_layer/p2p/src/comms_connector/pubsub.rs

@@ -254,6 +254,7 @@ mod test {
 
         assert_eq!(topic1b[0].a, 11);
         assert_eq!(topic1b[1].a, 33);
+        assert_eq!(topic1b[1].b, "three three");
 
         let topic2 = collect_stream!(sub2, take = 4, timeout = Duration::from_secs(10));
 

base_layer/p2p/src/dns/client.rs

@@ -106,7 +106,7 @@ impl DnsClient {
 #[derive(Clone)]
 pub struct Client<C> {
     inner: C,
-    shutdown: Arc<Shutdown>,
+    _shutdown: Arc<Shutdown>,
 }
 
 impl Client<AsyncDnssecClient> {
@@ -121,7 +121,7 @@ impl Client<AsyncDnssecClient> {
 
         Ok(Self {
             inner: client,
-            shutdown: Arc::new(shutdown),
+            _shutdown: Arc::new(shutdown),
         })
     }
 }
@@ -135,7 +135,7 @@ impl Client<AsyncClient> {
 
         Ok(Self {
             inner: client,
-            shutdown: Arc::new(shutdown),
+            _shutdown: Arc::new(shutdown),
         })
     }
 }
@@ -165,7 +165,7 @@ mod mock {
             let client = MockClientHandle::mock(messages);
             Ok(Self {
                 inner: client,
-                shutdown: Arc::new(Shutdown::new()),
+                _shutdown: Arc::new(Shutdown::new()),
             })
         }
     }

base_layer/p2p/src/services/liveness/state.rs

@@ -74,7 +74,6 @@ pub struct LivenessState {
     pongs_received: usize,
     pings_sent: usize,
     pongs_sent: usize,
-    num_active_peers: usize,
 
     local_metadata: Metadata,
 }

comms/dht/src/network_discovery/discovering.rs

@@ -41,21 +41,17 @@ const LOG_TARGET: &str = "comms::dht::network_discovery";
 pub(super) struct Discovering {
     params: DiscoveryParams,
     context: NetworkDiscoveryContext,
-    candidate_peers: Vec<PeerConnection>,
     stats: DhtNetworkDiscoveryRoundInfo,
     neighbourhood_threshold: NodeDistance,
-    excluded_peers: Vec<NodeId>,
 }
 
 impl Discovering {
     pub fn new(params: DiscoveryParams, context: NetworkDiscoveryContext) -> Self {
         Self {
             params,
             context,
-            candidate_peers: Vec::new(),
             stats: Default::default(),
             neighbourhood_threshold: NodeDistance::max_distance(),
-            excluded_peers: Vec::new(),
         }
     }
 

comms/src/multiplexing/yamux.rs

@@ -144,7 +144,7 @@ impl Control {
         let stream = self.inner.open_stream().await?;
         Ok(Substream {
             stream: stream.compat(),
-            counter_guard,
+            _counter_guard: counter_guard,
         })
     }
 
@@ -193,7 +193,7 @@ impl Stream for IncomingSubstreams {
         match futures::ready!(Pin::new(&mut self.inner).poll_recv(cx)) {
             Some(stream) => Poll::Ready(Some(Substream {
                 stream: stream.compat(),
-                counter_guard: self.substream_counter.new_guard(),
+                _counter_guard: self.substream_counter.new_guard(),
             })),
             None => Poll::Ready(None),
         }
@@ -209,7 +209,7 @@ impl Drop for IncomingSubstreams {
 #[derive(Debug)]
 pub struct Substream {
     stream: Compat<yamux::Stream>,
-    counter_guard: AtomicRefCounterGuard,
+    _counter_guard: AtomicRefCounterGuard,
 }
 
 impl StreamId for Substream {