Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update toolchain to nightly-2021-09-18 #3514

Merged
merged 1 commit into from
Nov 1, 2021

Commits on Nov 1, 2021

  1. Update toolchain to nightly-2021-09-18

    This seemingly innoucous update required several changes due to changes
    in how the compiler interprets dead code.
    
    * A few variables were renamed _x where it looked like x might be used
      in upcoming PRs. YAGNI maybe, but I gave the benefit of the doubt in
    this cases.
    * Some crates that had LOADS of dead code (ffi crate I'm looking at
      you), I just changed the `deny(dead_code)` to `warn(dead_code)`
    * And in some places, I just nuked the dead code, which tidied up some
      heavy code in the wallet in particular. Since the tests pass, I
    presume this is fine and there isn't a weird new compioler bug that is
    missing where the code is needed.
    
    Update hardcoded toolchain specs
    
    ..and update circleCI config
    
    PRevent multiplexing in docker CI
    CjS77 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    af7e38f View commit details
    Browse the repository at this point in the history