Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change status line #3610

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Nov 23, 2021

Description

Added NodeId to status line.
And status line is printed with more info (currently RandomX) every 2 minutes.

How Has This Been Tested?

Manually.

@Cifko
Copy link
Contributor Author

Cifko commented Nov 23, 2021

Is there a better way than adding Mutex? In any other language it would be a 4 line change. But this looks crazy to me to do all that for one mutable variable. Another solution that came to my mind is to just grab the time and print it on every % 5 minute (so every fifth minute, but that looks wrong on different level).

@stringhandler
Copy link
Collaborator

Yeah, but it's not a bad time to add a mutex around that command handler. Technically only one command should run at a time anyway

@aviator-app aviator-app bot merged commit 086cd0c into tari-project:development Nov 26, 2021
sdbondi added a commit to sdbondi/tari that referenced this pull request Dec 6, 2021
* development: (29 commits)
  fix(pruned mode)!: prune inputs, allow horizon sync resume and other fixes (tari-project#3521)
  feat!: sending one-sided transactions in wallet_ffi (tari-project#3634)
  fix: use json 5 for tor identity (regression) (tari-project#3624)
  test: add operation_id to log messages (tari-project#3633)
  fix!: multiple monerod addresses in tari merge mining proxy (tari-project#3628)
  fix: get-peer command works with public key again (tari-project#3636)
  fix!: separate peer seeds to common.network (tari-project#3635)
  test: removed stress test log target (tari-project#3631)
  feat: removed transaction validation redundant events (tari-project#3630)
  feat: improve wallet responsiveness (tari-project#3625)
  feat: add bulletproof rewind profiling (tari-project#3618)
  fix!: console wallet grpc_console_wallet_addresss config (tari-project#3619)
  test: increase timeout in cucumber (tari-project#3621)
  chore: change status line (tari-project#3610)
  feat!: add tcp bypass settings for tor in wallet_ffi (tari-project#3615)
  feat: only trigger UTXO scanning when a new block event is received (tari-project#3620)
  feat: implement dht pooled db connection (tari-project#3596)
  feat: add page for detailed mempool in explorer (tari-project#3613)
  chore: add pub key in the dailes notify (tari-project#3612)
  feat: display network for console wallet (tari-project#3611)
  ...
@Cifko Cifko deleted the add-sync-from branch January 9, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants