Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collectibles): add form validation error when committee not set #3750

Merged
merged 2 commits into from
Jan 26, 2022
Merged

feat(collectibles): add form validation error when committee not set #3750

merged 2 commits into from
Jan 26, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 26, 2022

Description

  • Add alert on save click when no committee members were added
  • Adds eslint rules (rules chosen to limit lines of code changed, not based on any preference I have, defaults are probably best)

Motivation and Context

Dont submit the form unless at least one committee member is chosen

How Has This Been Tested?

Manually

delta1
delta1 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviator-app aviator-app bot merged commit dfdaf4b into tari-project:development Jan 26, 2022
@sdbondi sdbondi deleted the collectibles-committee-error branch January 26, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delta1 delta1 delta1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdbondi @delta1