Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to compile on stable rust #3759

Merged
merged 15 commits into from
Feb 2, 2022

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Jan 26, 2022

Description

  • keeps the nightly tool chain, necessary for our cargo fmt settings and
    avx2, wasm features
  • but adds ability to compile with default features on stable and CI to check that

Closes #3035

@delta1
Copy link
Contributor Author

delta1 commented Jan 26, 2022

lol I tested clippy, didn't realize format would have an issue

Current fmt settings require nightly

@delta1 delta1 marked this pull request as draft January 27, 2022 07:43
@delta1 delta1 marked this pull request as ready for review January 30, 2022 18:42
@delta1 delta1 changed the title feat: compile on stable rust feat: ability to compile on stable rust Jan 30, 2022
stringhandler
stringhandler previously approved these changes Jan 31, 2022
@aviator-app aviator-app bot added the mq-failed label Feb 1, 2022
@delta1 delta1 removed the mq-failed label Feb 1, 2022
@aviator-app aviator-app bot added the mq-failed label Feb 1, 2022
@delta1 delta1 removed the mq-failed label Feb 1, 2022
@stringhandler stringhandler merged commit c19db92 into tari-project:development Feb 2, 2022
@delta1 delta1 deleted the ci-stable-rust branch February 2, 2022 07:07
@delta1 delta1 mentioned this pull request Feb 2, 2022
8 tasks
sdbondi added a commit to sdbondi/tari that referenced this pull request Feb 8, 2022
* development:
  refactor: reduce log level of some messages (tari-project#3804)
  ci: move Apple IDs into envs (tari-project#3797)
  feat: read asset definitions from base layer (tari-project#3802)
  fix: bump flood ban messages config (tari-project#3799)
  docs: readme fixes (tari-project#3800)
  feat(wallet_ffi)!:  add base node connectivity callback to wallet ffi (tari-project#3796)
  fix: minor fixes on collectibles (tari-project#3795)
  refactor: outbound message pipeline, threads and mempool improvements (tari-project#3792)
  feat(collectibles): add delete committee member button (tari-project#3786)
  fix(comms): minor edge-case fix to handle inbound connection while dialing (tari-project#3785)
  fix(core)!: fix potential panic for sidechain merkle root with incorrect length (tari-project#3788)
  fix(core): reduce one block behind waiting period (tari-project#3798)
  feat: add specific LibWallet error code for “Fee is greater than amount” (tari-project#3793)
  fix: coinbase output recovery bug (tari-project#3789)
  feat(base-node): add number of active sync peers metric (tari-project#3784)
  chore: script to keep .gitkeep file (tari-project#3787)
  feat: re-use scanned range proofs (tari-project#3764)
  feat: ability to compile on stable rust (tari-project#3759)
  feat: add logging and config to collectibles (tari-project#3781)
  chore: remove debug info from get-mempool-state (tari-project#3782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Rust stable
3 participants