feat(core): add tip height metric #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-tip-metric
branch
from
7ffbbc4
to
2dccdd3
Compare
stringhandler
approved these changes
Mar 28, 2022
|
This PR gives @delta1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
base_node::blockchain::tip_heightmetric to track current tip heightMotivation and Context
The main reason for this is currently the tip height is extracted from the logs using Loki which does not support the
deltafunction.deltais needed to determine if the chain tip has moved or not within a timespan.Following query allows an alert to be created that checks that nothing has changed within 20 minutes (delta of 0 over 20 min timespan)
delta(tari_base_node::blockchain::tip_height[20m])How Has This Been Tested?
Manually: Metrics appearts in local prometheus instance