feat(core): new output features for changes in contracts #4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-change-features
sdbondi
previously approved these changes
Jun 9, 2022
applications/tari_app_grpc/src/conversions/sidechain_features.rs
Outdated
Show resolved
Hide resolved
applications/tari_app_grpc/src/conversions/sidechain_features.rs
Outdated
Show resolved
Hide resolved
applications/tari_app_grpc/src/conversions/sidechain_features.rs
Outdated
Show resolved
Hide resolved
|
@sdbondi I implemented the improvements on conversions that you suggested |
…c-change-features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SidechainFeaturesstruct.CommitteeSignaturesto wrap a list of signatures, in a similar fashion to the existingCommitteeMembers.Motivation and Context
We need a way to represent, in UTXO features, all the information needed to specify changes in a contract:
ContractUpdateProposal: specifies the new proposed constitution.ContractUpdateProposalAcceptance: acceptance, by a validator node, of a contract update proposal.ContractAmendment: ratification of a update proposal, specifying when it's going to be enforced in the base layer.How Has This Been Tested?