-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add more recent zero point for wallet birthday (see issue #4176) #4275
fix: add more recent zero point for wallet birthday (see issue #4176) #4275
Conversation
We introduce a The current implementation relies on the genesis block of a chosen network. At the moment, we default to the One can argue that this functionality is not at all required, and we should instead hardcode an initial zero point in time, and update it to the mainnet, at launch time. |
3e8b0e4
to
ab3999a
Compare
Description
--- Add logic to tackle issue #4176, which aims at improving birthday representation for Cipher Seed generation.
Motivation and Context
--- The goal of this PR is to resolve issue #4176. The current version is supposed to allow a more recent genesis for wallet birthdays (it actually depends on the genesis block of the Tari network, we wish to work with). Moreover, it updates the version. Moreover, if the birthday does not fit within the
u16
type range, we update to a new version.How Has This Been Tested?
--- Add simple tests to check if logic is correct.