feat: proposal acceptance signatures are submitted and validated #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Jul 13, 2022
base_layer/core/src/transactions/transaction_components/side_chain/contract_update_proposal.rs
Outdated
Show resolved
Hide resolved
sdbondi
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
output_contains_proposalfunctionAcceptanceManagernow also publishes update proposals, and with the correct signatureproposal_idvalue in fixtures is not consistentMotivation and Context
Proposal acceptances need to be signed by the validator node submitting them. Also, the base layer should validate that the signature is valid.
Similar to recent PRs, the proposal acceptance signatures follow:
e = H_1(signer_public_key || public_nonce || H_2(contract_id||proposal_id||proposal_commitment))How Has This Been Tested?