Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comms/dht): fixes invalid peer ban on invalid encrypted msg signature #4519

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 23, 2022

Description

  • fixes invalid ban of source peer on the encrypted message signature, which can only be validated by the sender (Examine peer banning logic #4339 )
  • add two additional unit tests for this case

Motivation and Context

Ref #4339
Previously, a sender may send a message with an invalid encrypted signature that cannot be validated and rejected by intermediate nodes. On receipt by the sender, an invalid signature is encountered and previously this would result in sending peer being banned. This PR changes this to only discard the message. The sender is only banned if unencrypted header data is malformed/invalid.

How Has This Been Tested?

New unit tests + existing tests + manually (no breaking changes)

@stringhandler stringhandler merged commit 7a2c95e into tari-project:development Aug 24, 2022
@sdbondi sdbondi deleted the comms-dht-fix-invalid-ban-on-encrypted-sig-validation branch November 15, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants