feat: wallet optimize output manager db operations #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_optimize_sql_queries
branch
3 times, most recently
from
9abc858
to
c53a61f
Compare
Optimized output manager database operations to do as much work as possible inside the SQL database instead of inside Rust code.
hansieodendaal
force-pushed
the
ho_optimize_sql_queries
branch
from
c53a61f
to
903351c
Compare
hansieodendaal
changed the title
| &conn, | ||
| )?; | ||
| } | ||
| update_outputs_with_tx_id_and_status_to_new_status( |
There was a problem hiding this comment.
Suggested change
| update_outputs_with_tx_id_and_status_to_new_status( | |
| // use a transaction here | |
| conn.transaction(|| { | |
| update_outputs_with_tx_id_and_status_to_new_status( |
| &conn, | ||
| )?; | ||
| } | ||
| diesel::update(outputs::table.filter(outputs::status.eq(OutputStatus::ShortTermEncumberedToBeReceived as i32))) |
There was a problem hiding this comment.
also add a transaction over these two statements
stringhandler
approved these changes
Sep 20, 2022
This was referenced Sep 20, 2022
stringhandler
pushed a commit
that referenced
this pull request
Sep 26, 2022
Description --- Added SQL transactions to the encumbering queries to make the entire operation atomic. _(This is a further safeguard as a follow-on to #4663.)_ Motivation and Context --- It is possible that an independent thread can change the same SQL data (outputs) that were selected and verified to be encumbered just before it is encumbered. Fixes #4701. How Has This Been Tested? --- Passed unit tests Passed cucumber tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimized output manager and contacts liveness database operations to do as much work as possible inside the SQL database instead of inside Rust code. These changes are most noticeable where a query would return a number of outputs and followed by updating each output one by one.
Motivation and Context
See #4621
How Has This Been Tested?