Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core)!: sort validate set by shard key #4952

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Nov 24, 2022

Description

Sorts VN set by shard id before returning it

Motivation and Context

Ref tari-project/rfcs#73

How Has This Been Tested?

Tests updated

@sdbondi sdbondi changed the title fix!(core): sort validate set by shard key fix(core)!: sort validate set by shard key Nov 24, 2022
@stringhandler stringhandler merged commit 349d429 into tari-project:feature-dan Nov 24, 2022
stringhandler pushed a commit to tari-project/tari-dan that referenced this pull request Nov 25, 2022
Description
---
- Fixes QC Merkle root mismatch
- add borsh encoding consensus hasher and tari_bor crate, so that it does not have to depend on tari_template_abi
- removed a number of panics
- domain separated hashing
- number of small fixes
- updated integration tests

Motivation and Context
---
Relies on tari-project/tari#4952

Fixes #218 

How Has This Been Tested?
---
Manually
Existing tests updated
sdbondi added a commit to sdbondi/tari that referenced this pull request Nov 28, 2022
* feature-dan:
  fix(core)!: sort validate set by shard key (tari-project#4952)
  update validator signature
  feat!: implement validator node registration as per RFC-0313 (tari-project#4928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants