feat: reset broken sync #4955
Merged
feat: reset broken sync #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
requested changes
Nov 25, 2022
| chain_strength_comparer: &dyn ChainStrengthComparer, | ||
| ) -> Result<(), ChainStorageError> { | ||
| let metadata = db.fetch_chain_metadata()?; | ||
| // lets clear out all remaining headers that done have a matching block |
There was a problem hiding this comment.
Suggested change
| // lets clear out all remaining headers that done have a matching block | |
| // lets clear out all remaining headers that don't have a matching block |
stringhandler
added
the
P-controversial
SWvheerden
force-pushed
the
sw_reset_broken_sync
branch
from
740166e
to
fad6820
Compare
| // height it will only trim the extra headers with no blocks | ||
| rewind_to_height(db, metadata.height_of_longest_chain())?; | ||
| let all_orphan_tips = db.fetch_all_orphan_chain_tips()?; | ||
| if all_orphan_tips.is_empty() { |
There was a problem hiding this comment.
Maybe this check should be before we rewind
There was a problem hiding this comment.
I specifically did not do this as I use the rewind code here to remove the "extra" headers.
I want to "main chain" to be "clean" after this run.
The intended case is this.
Header sync downloads 10 headers.
Block sync fails after 5.
That extra 5 headers will stay on top of the main chain till we remove them again. I want to remove them at this point regardless of whether the new tip is higher than our original one.
| if all_orphan_tips.is_empty() { | ||
| // we have no orphan chain tips, we have trimmed remaining headers, we are on the best tip we have, so lets | ||
| // return ok | ||
| return Ok(BlockAddResult::OrphanBlock); |
There was a problem hiding this comment.
We should probably rename this to ChainReorgResult
There was a problem hiding this comment.
And OrphanBlock to change to NoChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If sync fails resets chain to the highest pow chain the node locally has the data to.
Motivation and Context
See: #4866
How Has This Been Tested?
Unit tests